[WML-269] Add non-spark and non-dynamoDB and non-Flyte persistence method (shuffling) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickles-bread-and-butter
changed the base branch from
main
to
feature/sparkless_persistence
|
@isaak-willett - Just to confirm -is this a non-compatible change for existing wicker users? should customers have to update any of their workflows for this change? |
|
Nope they can use the version of wicker they are still using. It's new feature because it's a new class, it's compatible with old versions of datasets too. |
added 2 commits
October 26, 2022 19:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Add a method to persist data with shuffling using only s3 (no Flyte, DynamoDB, no spark). This is done by just using random.shuffle to shuffle the dataset if shuffle bool is True. This runs in O(N) time, the next step to get us more efficient is multi-proc this piece but that will be the next PR.
Changes: